Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Credentials improvements #9

Merged
merged 4 commits into from
Oct 4, 2023
Merged

Credentials improvements #9

merged 4 commits into from
Oct 4, 2023

Conversation

schmidtw
Copy link
Member

@schmidtw schmidtw commented Oct 4, 2023

No description provided.

schmidtw and others added 2 commits October 3, 2023 07:34
@guardrails
Copy link

guardrails bot commented Oct 4, 2023

⚠️ We detected 1 security issue in this pull request:

Vulnerable Libraries (1)
Severity Details
High pkg:golang/github.com/xmidt-org/[email protected] upgrade to: > v0.5.0

More info on how to fix Vulnerable Libraries in Go.


👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.

@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Merging #9 (98c5d8e) into main (73d9463) will increase coverage by 0.31%.
Report is 3 commits behind head on main.
The diff coverage is 94.08%.

@@            Coverage Diff             @@
##             main       #9      +/-   ##
==========================================
+ Coverage   92.23%   92.55%   +0.31%     
==========================================
  Files           9       11       +2     
  Lines         902     1075     +173     
==========================================
+ Hits          832      995     +163     
- Misses         51       60       +9     
- Partials       19       20       +1     
Flag Coverage Δ
unittests 92.55% <94.08%> (+0.31%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
config.go 87.23% <ø> (ø)
internal/fs/fs.go 100.00% <100.00%> (ø)
internal/fs/mem/file.go 100.00% <100.00%> (ø)
internal/fs/mem/mem.go 100.00% <100.00%> (+1.83%) ⬆️
internal/fs/options.go 100.00% <100.00%> (ø)
internal/credentials/options.go 83.87% <70.58%> (-2.12%) ⬇️
internal/credentials/credentials.go 90.19% <92.39%> (+0.15%) ⬆️

@schmidtw schmidtw merged commit 28e727a into main Oct 4, 2023
14 checks passed
@schmidtw schmidtw deleted the credentials-improvements branch October 4, 2023 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant