feat: update rdr codes for dropped message #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denopink
added
enhancement
For dropped messages, dispose of the payload and update the rdr code to the following: - rdr value of 4 for payloads too large - rdr value of 102 for lower priority messages
denopink
force-pushed
the
denopink/feat/qos-drop-message-response
branch
from
438d579 to
fcaeb57
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #232 +/- ##
=======================================
Coverage 77.55% 77.56%
=======================================
Files 74 74
Lines 4625 4626 +1
=======================================
+ Hits 3587 3588 +1
Misses 841 841
Partials 197 197
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
denopink
commented
Sep 13, 2024
| itm := heap.Pop(pq).(item) | ||
| // itm.discard will be true if `itm` has been marked to be discarded, | ||
| // i.e. trimmed by `pq.trim()'. | ||
| if itm.discard { |
There was a problem hiding this comment.
Previously we were discarding the message without sending any response back to xmidt
schmidtw
reviewed
Sep 13, 2024
schmidtw
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For dropped messages, dispose of the payload and update the rdr code to the following: