Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use webpa-interface-used from the command line to populate metadata #216

Merged
merged 6 commits into from
Aug 12, 2024

Conversation

piccione99
Copy link
Contributor

@piccione99 piccione99 commented Aug 6, 2024

Originally we wanted the websocket to loop through all possible interfaces in some sort of priority order and then populate whichever one it uses. But paradus doesn't do this. And we don't know enough how to do this and it seems like we would be re-inventing the wheel if RDK / tr181 is already handling this for us. For now, just copy whatever we are told into the metadata header.

  • removed InterfaceUsedProvider as it's no longer needed

note - all my changes are 100 percent unit test covered. codecoverage is complaining about coverage in files I removed code from (?)

Copy link

codecov bot commented Aug 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.66%. Comparing base (7f18261) to head (bacf645).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #216      +/-   ##
==========================================
+ Coverage   74.98%   77.66%   +2.67%     
==========================================
  Files          75       74       -1     
  Lines        4642     4625      -17     
==========================================
+ Hits         3481     3592     +111     
+ Misses        955      836     -119     
+ Partials      206      197       -9     
Flag Coverage Δ
unittests 77.66% <100.00%> (+2.67%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@piccione99 piccione99 requested review from schmidtw and denopink and removed request for schmidtw August 6, 2024 23:58
@piccione99 piccione99 merged commit 79674d4 into main Aug 12, 2024
17 of 18 checks passed
@piccione99 piccione99 deleted the ci2 branch August 12, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants