-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FR: Add simple message types validators for the WRP messages #85
FR: Add simple message types validators for the WRP messages #85
Conversation
Codecov Report
@@ Coverage Diff @@
## main #85 +/- ##
==========================================
+ Coverage 50.16% 50.97% +0.80%
==========================================
Files 21 24 +3
Lines 3827 3949 +122
==========================================
+ Hits 1920 2013 +93
- Misses 1736 1760 +24
- Partials 171 176 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super duper minor comments, otherwise lgtm!
* add missing comment on parent span component * typo
* Add concrete error types & update existing errors (the ones affected) * Update validator funcs to implement `ValidatorFunc` signature & update existing references * Add new api for `Validators` & update validator factories
* add missing comment on parent span component * typo
* Add concrete error types & update existing errors (the ones affected) * Update validator funcs to implement `ValidatorFunc` signature & update existing references * Add new api for `Validators` & update validator factories
…ithub.com/denopink/wrp-go into denopink/feature/SimpleMsgTypesValidators
* Update `ValidatorError`'s `Fields` to `[]string` * Update `NewValidatorError` to panic when both `err` and `m` are empty strings or nil
Overview
related to #25, #78, xmidt-org/scytale#88, xmidt-org/talaria#153 and builds on top of #80 and #84 .
tl;dr
This pr introduces our wrp
simple message types validators
built with our validation framework introduced in #80 and leverages basic spec validators introduced in #84 . Clients can leverage these prebuilt validators to validate their messages.Explanation
Clients can leverage our prebuilt validators to validate their messages, such as
SimpleEventValidators
andSimpleResponseRequestValidators
:Type of Change(s)