Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/ring #50

Merged
merged 9 commits into from
Dec 26, 2024
Merged

Refactor/ring #50

merged 9 commits into from
Dec 26, 2024

Conversation

johnabass
Copy link
Collaborator

Full refactoring to better support different kinds of distributed hashing

Copy link

codecov bot commented Dec 26, 2024

Codecov Report

Attention: Patch coverage is 60.64140% with 135 lines in your changes missing coverage. Please review.

Project coverage is 59.20%. Comparing base (a62ee3b) to head (2a266ae).
Report is 45 commits behind head on main.

Files with missing lines Patch % Lines
consistent/builder.go 0.00% 54 Missing ⚠️
consistent/ring.go 0.00% 43 Missing ⚠️
consistent/hasher.go 0.00% 32 Missing ⚠️
consistent/node.go 0.00% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##              main      #50       +/-   ##
============================================
- Coverage   100.00%   59.20%   -40.80%     
============================================
  Files            6        8        +2     
  Lines          301      353       +52     
============================================
- Hits           301      209       -92     
- Misses           0      144      +144     
Flag Coverage Δ
unittests 59.20% <60.64%> (-40.80%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johnabass johnabass merged commit 72469ab into main Dec 26, 2024
14 of 17 checks passed
@johnabass johnabass deleted the refactor/ring branch December 26, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant