Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial checkin ideas #209

Merged
merged 17 commits into from
Dec 1, 2023
Merged

initial checkin ideas #209

merged 17 commits into from
Dec 1, 2023

Conversation

johnabass
Copy link
Contributor

Proposal

Here's the basic shape of how I think bascule should be refactored. This approach is heavily inspired (who am I kidding ... plagiarized) from other security frameworks such as the excellent Spring Security.

@johnabass johnabass marked this pull request as draft August 25, 2023 20:20
@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d18b6b4) 85.56% compared to head (70771d3) 85.56%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #209   +/-   ##
=======================================
  Coverage   85.56%   85.56%           
=======================================
  Files          36       36           
  Lines        1482     1482           
=======================================
  Hits         1268     1268           
  Misses        196      196           
  Partials       18       18           
Flag Coverage Δ
unittests 85.56% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

guardrails bot commented Nov 30, 2023

⚠️ We detected 1 security issue in this pull request:

Vulnerable Libraries (1)
Severity Details
High pkg:golang/github.com/lestrrat-go/jwx/[email protected] upgrade to: > v2.0.12

More info on how to fix Vulnerable Libraries in Go.


👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.

@johnabass johnabass marked this pull request as ready for review November 30, 2023 22:06
@johnabass johnabass merged commit 2a6591f into main Dec 1, 2023
15 of 16 checks passed
@johnabass johnabass deleted the feature/redesign branch December 1, 2023 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant