fix: updated dependencies and fixed some errors on methods #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ters Upgrade onRequestPermissionsResult parameters for Android
mirland
reviewed
Jul 3, 2024
mirland
approved these changes
Jul 8, 2024
CHANGELOG.md
Outdated
| @@ -1,3 +1,7 @@ | |||
| # [0.4.1] - Moved to tflite flutter processor | |||
android/build.gradle
Outdated
| version '1.0-SNAPSHOT' | ||
|
|
||
| buildscript { | ||
| ext.kotlin_version = '1.3.50' | ||
| ext.kotlin_version = '1.6.10' |
There was a problem hiding this comment.
it's too old, we may want to update it.
android/build.gradle
Outdated
| @@ -1,8 +1,8 @@ | |||
| group 'com.tfliteflutter.tflite_flutter_helper' | |||
| group 'io.chaosdev.tflite_flutter_processing' | |||
| @@ -26,7 +26,7 @@ dependencies: | |||
| # The following adds the Cupertino Icons font to your application. | |||
| # Use with the CupertinoIcons class for iOS style icons. | |||
| cupertino_icons: ^1.0.2 | |||
| tflite_flutter_helper: | |||
| tflite_flutter_processing: | |||
There was a problem hiding this comment.
do we want to change the name? Maybe we want, but it's a question
| plugins { | ||
| id "dev.flutter.flutter-plugin-loader" version "1.0.0" | ||
| id "com.android.application" version "7.1.2" apply false | ||
| // id "org.jetbrains.kotlin.android" version "{kotlinVersion}" apply false |
There was a problem hiding this comment.
Suggested change
| // id "org.jetbrains.kotlin.android" version "{kotlinVersion}" apply false |
| } | ||
|
|
||
| include ":app" |
There was a problem hiding this comment.
Suggested change
| include ":app" | |
| include ":app" | |
pubspec.yaml
Outdated
| version: 0.3.0 | ||
| homepage: https://www.github.com/am15h/tflite_flutter_helper | ||
| version: 0.4.1 | ||
| homepage: https://www.github.com/lucasoskorep/tflite_flutter_processing |
pubspec.yaml
Outdated
|
|
||
| environment: | ||
| sdk: ">=2.12.0 <3.0.0" | ||
| flutter: ">=1.10.0" | ||
| sdk: '>=2.18.0 <4.0.0' |
| quiver: ^3.2.1 | ||
| path_provider: ^2.1.3 | ||
| tflite_flutter: ^0.10.4 | ||
| tuple: ^2.0.2 |
| tuple: ^2.0.2 | ||
| camera: ^0.11.0+1 | ||
| ffi: ^2.1.2 | ||
| image: ^4.2.0 |
There was a problem hiding this comment.
If we want to release, it should be multiple packages. One for image processor and other for other stuff
|
Check the tests before merge it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.