Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix linter issues #42

Merged
merged 6 commits into from
May 7, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions .github/workflows/dart-ci.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: Dart CI
on:
pull_request_target:
pull_request:
push:
branches:
- main
Expand All @@ -19,10 +19,9 @@ jobs:

- name: Verify formatting
run: dart format --output=none --set-exit-if-changed .

- name: Dart Analyze project source
run: dart analyze --fatal-infos

- uses: invertase/github-action-dart-analyzer@v1
with:
fatal-infos: true
- name: Flutter Analyze project source
run: flutter analyze .

Expand Down
15 changes: 7 additions & 8 deletions lib/src/stock_response.dart
Original file line number Diff line number Diff line change
Expand Up @@ -43,12 +43,11 @@ final class StockResponseLoading<T> extends StockResponse<T> {
String toString() => 'StockResponse<$T>.loading(origin: $origin)';

@override
bool operator ==(dynamic other) {
return identical(this, other) ||
(other.runtimeType == runtimeType &&
other is StockResponseLoading<T> &&
origin == other.origin);
}
bool operator ==(Object other) =>
identical(this, other) ||
(other.runtimeType == runtimeType &&
other is StockResponseLoading<T> &&
origin == other.origin);

@override
int get hashCode => Object.hash(runtimeType, origin.hashCode);
Expand All @@ -67,7 +66,7 @@ final class StockResponseData<T> extends StockResponse<T> {
String toString() => 'StockResponse<$T>.data(origin: $origin, value: $value)';

@override
bool operator ==(dynamic other) =>
bool operator ==(Object other) =>
identical(this, other) ||
(other.runtimeType == runtimeType &&
other is StockResponseData<T> &&
Expand Down Expand Up @@ -97,7 +96,7 @@ final class StockResponseError<T> extends StockResponse<T> {
'stackTrace: $stackTrace)';

@override
bool operator ==(dynamic other) =>
bool operator ==(Object other) =>
identical(this, other) ||
(other.runtimeType == runtimeType &&
other is StockResponseError<T> &&
Expand Down
38 changes: 19 additions & 19 deletions pubspec.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 6 additions & 6 deletions pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,12 @@ environment:

dependencies:
meta: ^1.3.0
mutex: ^3.0.0
mutex: ^3.1.0
rxdart: ^0.27.2

dev_dependencies:
build_runner: 2.4.6
lints: 2.1.1
mockito: 5.4.2
test: 1.24.7
very_good_analysis: 5.1.0
build_runner: ^2.4.9
lints: ^3.0.0
mockito: ^5.4.4
test: ^1.25.5
very_good_analysis: ^5.1.0
4 changes: 3 additions & 1 deletion test/common_mocks.mocks.dart

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading