Make SOT optional in the Stock constructor (#33)

xmartlabs · Nov 18, 2022 · 5e5aede · 5e5aede
1 parent 239090a
commit 5e5aede
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 6 deletions.
diff --git a/.github/workflows/dart-ci.yml b/.github/workflows/dart-ci.yml
@@ -12,15 +12,21 @@ jobs:
     steps:
       - uses: actions/checkout@v3
       - uses: dart-lang/setup-dart@v1
+      - uses: subosito/flutter-action@v2
+        with:
+          channel: 'stable'
       - name: Install dependencies
         run: dart pub get
 
       - name: Verify formatting
         run: dart format --output=none --set-exit-if-changed .
 
-      - name: Analyze project source
+      - name: Dart Analyze project source
         run: dart analyze --fatal-infos
 
+      - name: Flutter Analyze project source
+        run: flutter analyze .
+
       - name: Analyze project source - Code Metrics
         run: |
           result=$(dart run dart_code_metrics:metrics analyze lib  --fatal-style --fatal-performance --fatal-warnings)

diff --git a/lib/src/stock.dart b/lib/src/stock.dart
@@ -18,7 +18,7 @@ abstract class Stock<Key, T> {
   /// Stock constructor
   factory Stock({
     required Fetcher<Key, T> fetcher,
-    required SourceOfTruth<Key, T>? sourceOfTruth,
+    SourceOfTruth<Key, T>? sourceOfTruth,
   }) =>
       StockImpl<Key, T>(fetcher: fetcher, sourceOfTruth: sourceOfTruth);
 

diff --git a/test/store_valid_result_store_test.dart b/test/store_valid_result_store_test.dart
@@ -75,10 +75,7 @@ void main() {
     test('Test a stock with only a stream fetcher', () async {
       final fetcher =
           Fetcher.ofStream((int key) => Stream.fromIterable([1, 2, 3]));
-      final stock = Stock<int, int>(
-        fetcher: fetcher,
-        sourceOfTruth: null,
-      );
+      final stock = Stock<int, int>(fetcher: fetcher);
 
       final resultList = await stock.getFreshResult(1);
       expect(