feat: Firebase analytics integration #69
Open
+40
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirland
changed the title
nicolantean
approved these changes
Dec 19, 2024
Comment on lines
17
to
+18
| static const crashlyticsEnabled = !kIsWeb && !debugMode; | ||
| static const analyticsEnabled = !kIsWeb && !debugMode; |
There was a problem hiding this comment.
what about using just one constant for both?
There was a problem hiding this comment.
are you talking about analyticsEnabled and crashlyticsEnabled?
fedecor9
reviewed
Dec 19, 2024
| await Config.getEnvFromBundleId(), | ||
| ), | ||
| ); | ||
| unawaited( |
There was a problem hiding this comment.
Disable automatic collection, if it's not configured properly it can track data that is not valid
await _firebaseAnalytics.app.setAutomaticDataCollectionEnabled(false);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.