chore: update deps #307
Merged
chore: update deps #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f7deleon
force-pushed
the
chore/update-deps
branch
from
86ac56f to
f61eff6
Compare
mirland
approved these changes
May 6, 2024
app/build.gradle
Outdated
| "-Xuse-experimental=kotlinx.coroutines.FlowPreview", | ||
| "-Xuse-experimental=kotlin.ExperimentalStdlibApi", | ||
| "-opt-in=kotlin.RequiresOptIn", | ||
| "-opt-in=kotlin.time.ExperimentalTime", |
There was a problem hiding this comment.
Suggested change
| "-opt-in=kotlin.time.ExperimentalTime", |
app/build.gradle
Outdated
| ] | ||
| } | ||
| composeOptions { | ||
| kotlinCompilerExtensionVersion libs.versions.compose.core.get() | ||
| kotlinCompilerExtensionVersion = "1.5.11" |
There was a problem hiding this comment.
is it ok? Because kntlin is in something loke 1.9
There was a problem hiding this comment.
yes i updated to 1.5.13 but its the latest release of the kotlinCompilerExtensions
| @@ -143,7 +142,7 @@ dependencies { | |||
| implementation libs.bundles.kotlin | |||
| implementation libs.bundles.networking.core | |||
|
|
|||
| kapt libs.androidX.room.compiler | |||
| ksp libs.androidX.room.compiler | |||
|
|
||
| @SuppressWarnings("MagicNumber") | ||
| private val HTTP_READ_TIMEOUT = Duration.seconds(20) | ||
| private val HTTP_READ_TIMEOUT = 20.toDuration(DurationUnit.SECONDS) |
There was a problem hiding this comment.
shouldn't you use 20.seconds?
| See https://developer.android.com/about/versions/12/backup-restore#xml-changes | ||
| for details. | ||
| --> | ||
| <data-extraction-rules> |
There was a problem hiding this comment.
yes since allow backup was deprecated we need this file
build.gradle
Outdated
| @@ -19,21 +19,27 @@ buildscript { | |||
| } | |||
| } | |||
|
|
|||
| plugins{ | |||
| id 'com.google.devtools.ksp' version '1.9.23-1.0.20' apply false | |||
There was a problem hiding this comment.
cannot we get it from the version file?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Updated template version to the latest added signout feature