-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Cloudlab docs #250
Add Cloudlab docs #250
Conversation
046a29e
to
a89d5bd
Compare
@whentojump why adding a doc breaks the regression tests? |
I am having the exact same questions. I had several PRs which I believe don't touch much of the core code there. Let me look into the CI configs a bit later |
It says,
Sees a permission issue |
Nice research. @tianyin After looking around, I'd like first to clarify, the failed part is not regression tests, but a commenting bot achieving something like this Second, the improper permission has much to do with the fact that my PRs so far (including this one) all originate from my own fork. See GitHub docs (the rightmost column of the table, and the first bullet of "Notes" for workaround). Since the potential solution requires modifying the main branch, I'll do some experiments before actually pushing it. And before that, my future PRs will be created directly from this repository. |
I didn't do much research but a google search..
Yes. That's a good workaround, and explains why others don't hit the problem. Note that you have maintainer's role. |
If it makes things simpler, feel free to close the PRs and open it again within the repo. |
Let me first try fixing this CI peculiarity, for
|
245d8b8
to
a89d5bd
Compare
a89d5bd
to
c558a97
Compare
c0b3438
to
6b2c31b
Compare
6b2c31b
to
6491920
Compare
Known issues:
Partly resolves #242