Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update for some upstream patch #388

Merged
merged 5 commits into from
Nov 22, 2024
Merged

update for some upstream patch #388

merged 5 commits into from
Nov 22, 2024

Conversation

xiaods
Copy link
Owner

@xiaods xiaods commented Nov 22, 2024

No description provided.

* Use clientv3.NewCtxClient instead of New to avoid automatic retry of all RPCs
* Only timeout status requests; allow defrag and alarm clear requests to run to completion.
* Only clear alarms on the local cluster member, not ALL cluster members

Signed-off-by: Brad Davidson <[email protected]>
(cherry picked from commit 095e34d)
Signed-off-by: Brad Davidson <[email protected]>
porting by
Signed-off-by: Deshi Xiao <[email protected]>
Signed-off-by: Brad Davidson <[email protected]>
(cherry picked from commit a39e191)
Signed-off-by: Brad Davidson <[email protected]>
porting by
Signed-off-by: Deshi Xiao <[email protected]>
Signed-off-by: Brad Davidson <[email protected]>
(cherry picked from commit bc60ff7)
Signed-off-by: Brad Davidson <[email protected]>
porting by
Signed-off-by: Deshi Xiao <[email protected]>
Add new flag that is passed through to the device_ownership_from_security_context parameter in the containerd CRI config. This is not possible to change without providing a complete custom containerd.toml template so we should add a flag for it.

Signed-off-by: Brad Davidson <[email protected]>
(cherry picked from commit 56fb3b0)
Signed-off-by: Brad Davidson <[email protected]>
porting by
Signed-off-by: Deshi Xiao <[email protected]>
External CLI actions cannot short-circuit on --help or --version, so we
cannot skip loading the config file if these flags are present when
running these wrapped commands. The behavior of just returning the
override flag name instead of the requested flag value was breaking
data-dir lookup when running wrapped commands.

Signed-off-by: Brad Davidson <[email protected]>
(cherry picked from commit ff5c633)
Signed-off-by: Brad Davidson <[email protected]>
porting by
Signed-off-by: Deshi Xiao <[email protected]>
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
22.4% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Copy link
Contributor

Unit Test Results

274 tests   274 ✔️  4m 13s ⏱️
101 suites      0 💤
    1 files        0

Results for commit 94d2940.

@xiaods xiaods merged commit b1489ee into main Nov 22, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant