Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display intent filters of activities, services and broadcast receivers #52

Merged
merged 4 commits into from
Oct 15, 2020
Merged

Display intent filters of activities, services and broadcast receivers #52

merged 4 commits into from
Oct 15, 2020

Conversation

ekrmh
Copy link
Contributor

@ekrmh ekrmh commented Oct 12, 2020

Fix #51 #34

Solution

According my research we can not obtain intent filters from package manager. Hence currently parsing AndroidManifest.xml file is a only solution to obtain intent-filters.
Google Issue Tracker - Support PackageManager.GET_INTENT_FILTERS

This PR parses the AndroidManifest.xml file, obtain intent-filters of activities, services and broadcast receivers and display them in the app detail page.

Screenshot_20201012_134606_fr xgouchet packageexplorer debug

Update ( 14bd36e )

  • Intent filters displayed one by one instead of single text.
  • Intent filters made copyable after click the item.

Screenshot_20201014_021817_fr xgouchet packageexplorer debug

Update ( 30a3294 )

  • AppInfoWithSubtitle changed to AppInfoSimple
  • Displayed missing informations (icon, label, priority, type etc. ).
  • AndroidManifest.xml file exported and parsed only one time.
  • Multiple intent filters inside activity, services or broadcast receiver supported.

Screenshot_20201015_180652_fr xgouchet packageexplorer debug

Update ( 7a7a2d2 )

  • AndroidManifest file for ApkDetailsSource has been parsed.
  • Separator textview added to BulletViewHolder

Screenshot_20201015_191437_fr xgouchet packageexplorer debug

@xgouchet
Copy link
Owner

Overall nice work, thanks @ekrmh
My main concern with this implementation is that the whole information is combined in a single text view, meaning that we loose clarity, and the automatic copy to clipboard on tap copies the whole thing, which makes it useless.
I'm ok with your approach of displaying the data itself, but maybe you can add one item per intent filter. Another approach would be to add an action with a ➕ icon on activities, services etc… and open a new screen to get the details about the intent filters and meta data for that specific component.

@ekrmh
Copy link
Contributor Author

ekrmh commented Oct 13, 2020

@xgouchet Thanks for the comment. I understood your concern. In my opinion, displaying intent filters one by one will be better approach than displaying them in a new screen. I will update PR and show the intent filters one by one on the detail screen if appropriate for you and they will be copyable.

@ekrmh ekrmh requested a review from xgouchet October 15, 2020 15:28
Copy link
Owner

@xgouchet xgouchet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, just two quick requests and then it'll be good to go!

@ekrmh ekrmh requested a review from xgouchet October 15, 2020 16:17
Copy link
Owner

@xgouchet xgouchet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice work @ekrmh , thanks a lot

@xgouchet xgouchet merged commit db2ae3a into xgouchet:main Oct 15, 2020
@ekrmh
Copy link
Contributor Author

ekrmh commented Oct 15, 2020

@xgouchet Thanks, I would like to contribute more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants