-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display intent filters of activities, services and broadcast receivers #52
Conversation
…s in the detail page
Overall nice work, thanks @ekrmh |
@xgouchet Thanks for the comment. I understood your concern. In my opinion, displaying intent filters one by one will be better approach than displaying them in a new screen. I will update PR and show the intent filters one by one on the detail screen if appropriate for you and they will be copyable. |
app/src/main/java/fr/xgouchet/packageexplorer/details/DetailsSource.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/fr/xgouchet/packageexplorer/details/DetailsSource.kt
Outdated
Show resolved
Hide resolved
Code refactoring
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, just two quick requests and then it'll be good to go!
app/src/main/java/fr/xgouchet/packageexplorer/details/app/AppDetailsSource.kt
Show resolved
Hide resolved
…n ApkDetailsSource
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice work @ekrmh , thanks a lot
@xgouchet Thanks, I would like to contribute more. |
Fix #51 #34
Solution
According my research we can not obtain intent filters from package manager. Hence currently parsing AndroidManifest.xml file is a only solution to obtain intent-filters.
Google Issue Tracker - Support PackageManager.GET_INTENT_FILTERS
This PR parses the AndroidManifest.xml file, obtain intent-filters of activities, services and broadcast receivers and display them in the app detail page.
Update ( 14bd36e )
Update ( 30a3294 )
Update ( 7a7a2d2 )