-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add inferring metrics notebook #7
base: master
Are you sure you want to change the base?
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Thank you very much for migrating this. The tests are failing, because the data you are using is not stored in the repository itself anymore. I uploaded it to zenodo. You can simply copy the code to load it from there into the notebook:
It should be pretty much the same as in |
I think I am getting used to this work flow. After I change the file from zenodo, checks still failed. But this time it is on purpose so that one can see where the error was thrown if the metrics are not provided correctly. So how to resolve this? @jbusecke |
I see. That is a very good question indeed. Looping in @rabernat here. @miniufo has created this nice notebook, which illustrates some examples that produce failing cells (something that I also often do), but since these cells prevent the notebook to be executed in one go, binderbot is failing. Do you have a recommended workaround for this? My only idea would be to wrap both the code and the error in Markdown and make them 'non-interactive' but maybe there is a better way? |
I guess we don't have any better way right now? So I'll wrap them in Markdown. If there is a better way, I may send another commit. |
Yes! You use the expectexception package, as in this notebook: |
Hi @miniufo thanks for persisting on this. From what I understand you shouldnt see any difference, except that you should be able to have a code cell underneath the failing one, and would still be able to run the full notebook. I think this magic basically just prevents the notebook execution from stopping when it hits an error. Can you try to put |
Ok as suspected we need to provide the module to the binder environment. Let me check how to do that... Just trying to figure out what the least messy way to do this is. |
Hi @jbusecke, I am now sending the
inferring metrics
notebook in this PR. If this is OK, I'll close xgcm/xgcm#196.