Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use meson to build the wheel #55

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Conversation

ocefpaf
Copy link
Contributor

@ocefpaf ocefpaf commented Jun 26, 2024

This modernize the packaging and wheel building with:

  • numpy 2.0 support
  • Python 3.9-3.12
  • Run tests in GitHub Actions
  • fixes a the gufunc signature (same as Fix gufunc signature #51)

It is building on all platforms but the tests are passing only on Linux.

Ping @weiji14 and @scottyhq.

@ocefpaf ocefpaf force-pushed the use_meson branch 6 times, most recently from e161c4b to 897b867 Compare June 26, 2024 13:42
@ocefpaf
Copy link
Contributor Author

ocefpaf commented Jun 26, 2024

Linux: 34 passed, 0 failed
Windows: 12 failed, 22 passed
macOS: 8 failed, 26 passed

I don't think this package was tested on Windows or macOS before, so maybe the failures that are showing up were already there. MacOS ones seems to be related to numeric precision.


Edit: I won't fix the failing test on Windows and macOS b/c I don't have experience with CAPE to do this. My PR here goes as far as fixing the CIs and build it for Linux.

If you don't want a failing CI I can remove Windows and macOS tests to keep in line with what existed before in the Travis-CI config.

@weiji14
Copy link

weiji14 commented Jun 27, 2024

Edit: I won't fix the failing test on Windows and macOS b/c I don't have experience with CAPE to do this. My PR here goes as far as fixing the CIs and build it for Linux.

If you don't want a failing CI I can remove Windows and macOS tests to keep in line with what existed before in the Travis-CI config.

No experience with CAPE either, but from a conda-forge packaging perspective, I'd reckon it's ok to drop the Windows CI since it's not being built. As for macOS, you could maybe xfail those tests for now, and someone could look at whether the numerical precision errors are ok later?

@ocefpaf
Copy link
Contributor Author

ocefpaf commented Jun 28, 2024

I'd reckon it's ok to drop the Windows CI since it's not being built. As for macOS, you could maybe xfail those tests for now, and someone could look at whether the numerical precision errors are ok later?

I'm not a dev it maintainer here so, while I agree with you, it is not up to me to decide. I would merge the PR as is though, to remind to come back to the failing tests ASAP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants