implement audio playback by setting force-window property #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Happy new year!
This pr provides an easy implementation to support audio playback for #18
Firstly, declare a list that contains some common formats of music application. (e.g. m4a for Netease Music, mp3 for QQ Music)
Secondly, add a new item to observed_property, file_format.
Thirdly, if Macast find a casting file format in the AudioFormat, send a command to set
--force-windowproperty so that mpv window will display as the music starts to play. reference of why we can set options at runtime, see the 'Note' below the title.Finally, while casting a song from Netease Music, Macast's behaviour is as follow.
Looking forward to your code review :)