Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: add wgsl target and move module printing test case to filecheck #3615

Merged
merged 2 commits into from
Dec 11, 2024

Conversation

superlopuh
Copy link
Member

A bit of cleanup

@superlopuh superlopuh added the misc Miscellaneous label Dec 10, 2024
@superlopuh superlopuh self-assigned this Dec 10, 2024
@superlopuh superlopuh requested a review from compor December 10, 2024 11:45
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.47%. Comparing base (f7d39a1) to head (143ff2d).
Report is 13 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3615      +/-   ##
==========================================
+ Coverage   90.41%   90.47%   +0.06%     
==========================================
  Files         471      472       +1     
  Lines       59138    59275     +137     
  Branches     5611     5640      +29     
==========================================
+ Hits        53471    53631     +160     
+ Misses       4224     4205      -19     
+ Partials     1443     1439       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@alexarice alexarice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The title claims the test has been moved to filecheck, but it seems like a new test is created and the old isn't deleted?

@superlopuh superlopuh merged commit 1baf7d8 into main Dec 11, 2024
15 checks passed
@superlopuh superlopuh deleted the sasha/printer/wgsl-target branch December 11, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
misc Miscellaneous
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants