Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transformations: (apply-individual-rewrite) improve error message #3603

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

alexarice
Copy link
Collaborator

Think this is more readable

@alexarice alexarice requested a review from superlopuh December 9, 2024 11:54
@alexarice alexarice self-assigned this Dec 9, 2024
@alexarice alexarice added minor For minor PRs, easy and quick to review, quickly mergeable transformations Changes or adds a transformatio labels Dec 9, 2024
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.38%. Comparing base (4b51d2b) to head (b9e6f47).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3603   +/-   ##
=======================================
  Coverage   90.38%   90.38%           
=======================================
  Files         469      469           
  Lines       59071    59071           
  Branches     5615     5615           
=======================================
  Hits        53393    53393           
  Misses       4232     4232           
  Partials     1446     1446           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@superlopuh
Copy link
Member

What's the diff in error message?

@alexarice
Copy link
Collaborator Author

before:

ValueError: Invalid rewrite (<xdsl.transforms.canonicalization_patterns.arith.AddiConstantProp object at 0x7fd2a64eb830>) for operation (AddiOp(%res = arith.addi %n, %two : i32)) at location 3.

after:

ValueError: Invalid rewrite (AddiConstantProp) for operation (AddiOp(%res = arith.addi %n, %two : i32)) at location 3.

Copy link
Member

@superlopuh superlopuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clear improvement

@alexarice alexarice merged commit cf90bde into main Dec 9, 2024
15 checks passed
@alexarice alexarice deleted the alexarice/better_message branch December 9, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor For minor PRs, easy and quick to review, quickly mergeable transformations Changes or adds a transformatio
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants