Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: use relative imports for conftest helper #3566

Closed
wants to merge 3 commits into from

Conversation

superlopuh
Copy link
Member

For some reason make pyright complains for me locally, even though my language server and the CI seem happy.

@superlopuh superlopuh added minor For minor PRs, easy and quick to review, quickly mergeable misc Miscellaneous labels Dec 4, 2024
@superlopuh superlopuh requested a review from compor December 4, 2024 10:01
@superlopuh superlopuh self-assigned this Dec 4, 2024
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.40%. Comparing base (d81d66d) to head (7bc0bee).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3566   +/-   ##
=======================================
  Coverage   90.39%   90.40%           
=======================================
  Files         467      467           
  Lines       58857    58851    -6     
  Branches     5606     5606           
=======================================
  Hits        53206    53206           
+ Misses       4207     4201    -6     
  Partials     1444     1444           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@superlopuh
Copy link
Member Author

Something is weird, I can't be bothered ro fix it, I'll just try to fix my pyright.

@superlopuh superlopuh closed this Dec 4, 2024
@superlopuh superlopuh deleted the sasha/misc/relative-import-conftest branch December 6, 2024 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor For minor PRs, easy and quick to review, quickly mergeable misc Miscellaneous
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants