dialects: (arith) add addi constant propagation #3563
Merged
+56
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3563 +/- ##
==========================================
- Coverage 90.39% 90.39% -0.01%
==========================================
Files 467 467
Lines 58857 58870 +13
Branches 5606 5609 +3
==========================================
+ Hits 53206 53216 +10
- Misses 4207 4208 +1
- Partials 1444 1446 +2 ☔ View full report in Codecov by Sentry. |
n-io
approved these changes
Dec 3, 2024
superlopuh
reviewed
Dec 3, 2024
superlopuh
reviewed
Dec 3, 2024
Comment on lines
114
to
122
| %zero_plus = arith.addi %c0, %a : i32 | ||
| %plus_zero = arith.addi %a, %c0 : i32 | ||
|
|
||
| // CHECK: "test.op"(%a, %a) {"identity addition check"} : (i32, i32) -> () | ||
| "test.op"(%one_times, %times_one) {"identity addition check"} : (i32, i32) -> () | ||
|
|
||
| // CHECK: %plus_const = arith.addi %a, %c2 : i32 | ||
| %plus_const = arith.addi %c2, %a : i32 | ||
| "test.op"(%plus_const) : (i32) -> () |
There was a problem hiding this comment.
Suggested change
| %zero_plus = arith.addi %c0, %a : i32 | |
| %plus_zero = arith.addi %a, %c0 : i32 | |
| // CHECK: "test.op"(%a, %a) {"identity addition check"} : (i32, i32) -> () | |
| "test.op"(%one_times, %times_one) {"identity addition check"} : (i32, i32) -> () | |
| // CHECK: %plus_const = arith.addi %a, %c2 : i32 | |
| %plus_const = arith.addi %c2, %a : i32 | |
| "test.op"(%plus_const) : (i32) -> () | |
| %zero_plus = arith.addi %c0, %a : i32 | |
| %plus_zero = arith.addi %a, %c0 : i32 | |
| // CHECK: %plus_const = arith.addi %a, %c2 : i32 | |
| %plus_const = arith.addi %c2, %a : i32 | |
| "test.op"(%plus_const) : (i32) -> () |
There was a problem hiding this comment.
Unless I'm missing something, it looks like this is a copy/paste from above, but is not necessary
There was a problem hiding this comment.
ooh, it is necessary but should be %zero_plus and %plus_zero instead of %one_times and %times_one
There was a problem hiding this comment.
It was also a copy paste
superlopuh
approved these changes
Dec 3, 2024
|
Have fixed the test and resolved the conflict |
compor
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves constants to the right for an addi operation, similar to what #3557 did for muli. Also replaces
AddImmediateZerobyAddiIdentityRight, which removes constant zeros on the right of an addition instead of the left of an addition like the previous pattern did.Updates interactive tests (and driveby fixes the constant zero being given the SSA value name %two in this test).