transformations: adds a single pass from stencil to csl
#3231
Conversation
This pass combines (using a `PipelinePass`) all previously written passes and makes it easier to keep track of the order in which the passes need to be ran.
|
@n-io, is this order correct? Also where does |
xdsl/tools/command_line_tool.py
Outdated
| @@ -442,6 +447,7 @@ def get_stencil_bufferize(): | |||
| "convert-scf-to-riscv-scf": get_convert_scf_to_riscv_scf, | |||
| "convert-snitch-stream-to-snitch": get_convert_snitch_stream_to_snitch, | |||
| "convert-stencil-to-csl-stencil": get_convert_stencil_to_csl_stencil, | |||
| "convert-stencil-to-csl": get_convert_stencil_to_csl, | |||
There was a problem hiding this comment.
I would recommend calling it test-convert-stencil-to-csl, to minimise the confusion of alternative ways of getting to places. Ideally the csl work would actually have its own driver, and not use xdsl-opt, something like the toy command line tool that is toy-specific.
There was a problem hiding this comment.
Renamed as suggested.
Though, this is less of a driver, and more just a way to keep track of the order of passes developed so far.
There was a problem hiding this comment.
Though, this is less of a driver, and more just a way to keep track of the order of passes developed so far.
Well... Isn't that what the "driver" is though?
This would also allow us to add some simple logic to print the layout and program to multiple files and such. I guess we should discuss how to build actual compiler tools with xDSL (where you get an interface like stencilcc --march=cs2 my_input_file.mlir --out_dir=out that will write multiple files into ./out for the csl stencil work)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3231 +/- ##
==========================================
+ Coverage 90.07% 90.10% +0.03%
==========================================
Files 437 438 +1
Lines 54844 54889 +45
Branches 8518 8521 +3
==========================================
+ Hits 49402 49460 +58
+ Misses 4062 4052 -10
+ Partials 1380 1377 -3 ☔ View full report in Codecov by Sentry. |
|
What's the latest on this? It seems useful to me. I would just advise outlining the pass pipeline to a tuple available at the top of the file, I've found it useful for the equivalent riscv functionality. |
This pass combines (using a
PipelinePass) all previously written passes and makes it easier to keep track of the order in which the passes need to be ran.