[wip] interactive: load files into gui (7/7) #1802
Conversation
dshaaban01
requested review from
tobiasgrosser,
superlopuh,
compor,
math-fehr and
webmiche
There was a problem hiding this comment.
Not sure where this is going, but I would have preferred a file browser to pop up here.
I know this is a bigger feature, but now I have to move in and out of the application.
Also, I have no hints on what is the default path for the file I want to load.
Just a comment, so I'm not going to block this.
| @@ -301,6 +305,10 @@ def uncondense(self, event: Button.Pressed) -> None: | |||
| def remove_last_pass(self, event: Button.Pressed) -> None: | |||
| self.pass_pipeline = self.pass_pipeline[:-1] | |||
|
|
|||
| @on(Button.Pressed, "#load_file_button") | |||
| def load_file(self, event: Button.Pressed) -> None: | |||
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dalia/condense.5 #1802 +/- ##
====================================================
- Coverage 89.14% 89.14% -0.01%
====================================================
Files 260 260
Lines 32113 32120 +7
Branches 4735 4736 +1
====================================================
+ Hits 28628 28634 +6
- Misses 2789 2790 +1
Partials 696 696 ☔ View full report in Codecov by Sentry. |
|
Could you please make this a draft PR until it's ready to review? Makes it a bit easier to prioritise PRs |
|
Personally, I would first focus on only the first part before trying to load files while the gui is running. This should be relatively simple by changing the |
Goal of this PR:
xdsl-gui <filename>command to preload a file into gui input textareaSo far: text area and buttons widgets added for goal 2) but have not made it work yet. Advice/thoughts on this functionality welcome.