backend: (riscv) add 1d, 3d, and 4d snitch stream lowerings #1781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
superlopuh
requested review from
nazavode,
compor,
AntonLydike,
JosseVanDelm and
adutilleul
superlopuh
commented
Nov 13, 2023
Comment on lines
-8
to
-20
| %0 = "snitch_stream.stride_pattern"() {"ub" = [#builtin.int<2>, #builtin.int<3>], "strides" = [#builtin.int<24>, #builtin.int<8>], "dm" = #builtin.int<31>} : () -> !snitch_stream.stride_pattern_type | ||
| // CHECK-NEXT: %0 = riscv.li 2 : () -> !riscv.reg<> | ||
| // CHECK-NEXT: %1 = riscv.li 3 : () -> !riscv.reg<> | ||
| // CHECK-NEXT: %2 = riscv.li 24 : () -> !riscv.reg<> | ||
| // CHECK-NEXT: %3 = riscv.li 8 : () -> !riscv.reg<> | ||
| // CHECK-NEXT: %4 = riscv.addi %0, -1 : (!riscv.reg<>) -> !riscv.reg<> | ||
| // CHECK-NEXT: %5 = riscv.addi %1, -1 : (!riscv.reg<>) -> !riscv.reg<> | ||
| // CHECK-NEXT: "snitch.ssr_set_dimension_bound"(%4) {"dm" = #builtin.int<31>, "dimension" = #builtin.int<0>} : (!riscv.reg<>) -> () | ||
| // CHECK-NEXT: "snitch.ssr_set_dimension_bound"(%5) {"dm" = #builtin.int<31>, "dimension" = #builtin.int<1>} : (!riscv.reg<>) -> () | ||
| // CHECK-NEXT: "snitch.ssr_set_dimension_stride"(%2) {"dm" = #builtin.int<31>, "dimension" = #builtin.int<0>} : (!riscv.reg<>) -> () | ||
| // CHECK-NEXT: %6 = riscv.mul %4, %2 : (!riscv.reg<>, !riscv.reg<>) -> !riscv.reg<> | ||
| // CHECK-NEXT: %7 = riscv.sub %3, %6 : (!riscv.reg<>, !riscv.reg<>) -> !riscv.reg<> | ||
| // CHECK-NEXT: "snitch.ssr_set_dimension_stride"(%7) {"dm" = #builtin.int<31>, "dimension" = #builtin.int<1>} : (!riscv.reg<>) -> () |
There was a problem hiding this comment.
git got confused by the {{.*}} changes, but the only meaningful change is the addition of riscv.li 0, which will be optimised out anyway
Codecov ReportAll modified and coverable lines are covered by tests ✅
... and 7 files with indirect coverage changes 📢 Thoughts on this report? Let us know! |
nazavode
approved these changes
Nov 14, 2023
adutilleul
approved these changes
Nov 14, 2023
|
I'll double check that this works on simulator before merging, looking to merge today |
compor
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tested in the experiments repo that this works