interactive: app, add "clear passes" button (7/7) #1775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…played in the output)
Co-authored-by: Sasha Lopoukhine <[email protected]>
…ld tests merged into one larger one due to shared global variable + asynch tests.
…unction description + editing comment line length in code to fit column size.
….e make a new slate). test added as well to test this.
This reverts commit cdbff9c.
compor
reviewed
Nov 15, 2023
| p.name for p in self.passes_selection_list.selected | ||
| ) | ||
| new_label = f"xdsl-opt -p {new_passes}" | ||
| self.query_one(Label).update(new_label) |
There was a problem hiding this comment.
I agree here, that the documentation is confusing; and I think I've commented this on a previous PR.
If it is to use Textual's update model, I'd suggest avoiding documenting it as this is how the framework works and saves you from having to update 2 places in the source (functionality and documentation) if things change.
superlopuh
added a commit
that referenced
this pull request
Nov 16, 2023
Add "clear passes" query - removes the effect of passes from the input IR (i.e. input and output textarea are the same), deselects all passes from the selection list and removes the pass names from the query label. Displays the selected queries in the label.  --------- Co-authored-by: Sasha Lopoukhine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add "clear passes" query - removes the effect of passes from the input IR (i.e. input and output textarea are the same), deselects all passes from the selection list and removes the pass names from the query label.