Lets translate texts #56
Conversation
Add translation for the titles of the buttons, three sample languages in the source code, english, spanish and french. some code optimizations for window.open and some repeated html code
There was a problem hiding this comment.
I like the idea but there are couple of left-over debugging code and lot of formatting issue.
Regarding the formating issues I went ahead and added all the toolings for proper coding standard (we should have done this sooner - so apologies).
If it's not too much trouble then would you mind pulling the develop branch and working off of that? Let me know if there are any issue so that I can help merge this change.
You can run npm run prettier to auto-format all the js code in src/ directory.
You can run npm run lint to check for lint errors. (This should happen automatically when you try to push your changes to remote - this should also check for css lint errors along with js)
Unfortunately, there isn't one css auto-formatter like there is for js so you'd have to manually format css if there are any issues with css files.
| } | ||
| }; | ||
| var sharer = new SelectionSharer({elements:'p',lang:'ca',langs:langs}); | ||
| console.log(sharer); |
There was a problem hiding this comment.
Even though this is demo file can we get rid of console.log to keep the demo clean?
| } | ||
| }; | ||
| var sharer = new SelectionSharer({elements:'p',lang:'ca',langs:langs}); | ||
| console.log(sharer); |
There was a problem hiding this comment.
Same here with console.log
| @@ -14,10 +14,32 @@ | |||
| var SelectionSharer = function(options) { | |||
|
|
|||
| var self = this; | |||
|
|
|||
| this.lang = 'en'; | |||
| this.langs={ | |||
There was a problem hiding this comment.
The formatting is a bit off here.
| 'shareOn':'Partagez la sélection sur %s', | ||
| 'shareByMail':'Partagez la sélection par email', | ||
| 'quoteFrom':"Citation de " | ||
|
|
There was a problem hiding this comment.
Might want to get rid of extra line here as well.
| options = { elements: options }; | ||
| options = { elements: options }; | ||
| if(options.lang) | ||
| this.lang=options.lang; |
There was a problem hiding this comment.
Formatting issue here as well.
| if(options.lang) | ||
| this.lang=options.lang; | ||
| if(options.langs) | ||
| this.langs=options.langs; |
| var top = (screen.height - h) /2 - 100; | ||
| window.open(url, name, 'toolbar=no, location=no, directories=no, status=no, menubar=no, scrollbars=no, resizable=no, copyhistory=no, width='+w+', height='+h+', top='+top+', left='+left); | ||
| self.hide(); | ||
| }; |
There was a problem hiding this comment.
Probably needs just 4 space indentation here.
| var left = (screen.width/2)-(w/2); | ||
| var top = (screen.height/2)-(h/2)-100; | ||
| window.open(url, "share_twitter", 'toolbar=no, location=no, directories=no, status=no, menubar=no, scrollbars=no, resizable=no, copyhistory=no, width='+w+', height='+h+', top='+top+', left='+left); | ||
| self.windowOpen(url, "share_twitter"); |
There was a problem hiding this comment.
This needs 4 space indent too.
| }; | ||
|
|
||
| this.shareEmail = function(e) { | ||
| var text = self.textSelection.replace(/<p[^>]*>/ig,'\n').replace(/<\/p>| /ig,'').trim(); | ||
| var email = {}; | ||
| email.subject = encodeURIComponent("Quote from "+document.title); | ||
| email.subject = encodeURIComponent(salf.translate('quoteFrom')+document.title); |
There was a problem hiding this comment.
This probably has typo is this supposed to be self?
| email.body = encodeURIComponent("“"+text+"”")+"%0D%0A%0D%0AFrom: "+document.title+"%0D%0A"+window.location.href; | ||
| $(this).attr("href","mailto:?subject="+email.subject+"&body="+email.body); | ||
| self.hide(); | ||
| return true; | ||
| }; | ||
|
|
||
| this.translate = function(varText,Replace){ | ||
| // check for illegal language assignement, if lang is not defined uses english by default |
There was a problem hiding this comment.
Formatting issue in this block also.
Add translation for the titles of the buttons, three sample languages in the source code, english, spanish and french.
some code optimizations for window.open and some repeated html code