Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added option to fail immediately after single test fails #1374

Merged
merged 4 commits into from
Sep 12, 2023
Merged

added option to fail immediately after single test fails #1374

merged 4 commits into from
Sep 12, 2023

Conversation

0xMimir
Copy link
Contributor

@0xMimir 0xMimir commented Sep 9, 2023

When running code coverage on bigger projects, if test fails, tests for all other libraries and binaries are still runned, it would be nice to have a option to fail immediately after single test fails, like cargo test does.

Closes #1373

xd009642
xd009642 requested changes Sep 11, 2023
View reviewed changes
Copy link
Owner

@xd009642 xd009642 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So two small tidiness comments, and if you can update the changelog something like as follows:

## [Unreleased]
### Added
- Added `--fail-immediately` flag to abort execution the moment the first test failure occurs

### Changed

src/args.rs Outdated Show resolved Hide resolved
src/main.rs Outdated Show resolved Hide resolved
@0xMimir
Copy link
Contributor Author

0xMimir commented Sep 11, 2023

Fixed typos, removed commended lines and added changes to CHANGELOG.md

@xd009642
Copy link
Owner

Ah and cargo fmt is failing in CI so if you can run cargo fmt and push the resulting changes as well

@0xMimir
Copy link
Contributor Author

0xMimir commented Sep 11, 2023

I have added changes from cargo fmt

@xd009642 xd009642 merged commit 8a1ac06 into xd009642:develop Sep 12, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xd009642 xd009642 xd009642 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add option to fail immediately after single test fails
2 participants
@0xMimir @xd009642