Eliminate complicated redundancy in renderTickEvent #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the Gui checking to its own method, as it is used twice. This will make it easier to support additional Gui types (thinking about xbony2#38), and if necessary fix issues in the future with it because it will require one change rather than two identical changes. Move the copying code to its own method, because it is a very long string of method calls. copyString is a much more readable way of thinking about it if you do not care about *how* the string is copied. Switch the isCtrlKeyDown check to be non-inversed, since it is easier to think about that else clause that way.
trying really hard to not change everything into groovy syntax
xbony2
requested changes
Mar 1, 2018
| * empty ItemStack. | ||
| */ | ||
| @Nonnull | ||
| private ItemStack getHoveredItemStack(){ |
There was a problem hiding this comment.
Hmm, I think these would be better in the Utils class.
There was a problem hiding this comment.
I agree. I thought about it but wasn't totally sure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the Gui checking to its own method, as it is used twice. This will make it easier to support additional Gui types (thinking about #38), and if necessary fix issues in the future with it because it will require one change rather than two identical changes.
Move the copying code to its own method, because it is a very long string of method calls. copyString is a much more readable way of thinking about it if you do not care about how the string is copied.
Switch the isCtrlKeyDown check to be non-inversed, since it is easier to think about that else clause that way.