Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doesn't work in JEI #38

Open
elifoster opened this issue Jan 20, 2018 · 0 comments
Open

Doesn't work in JEI #38

elifoster opened this issue Jan 20, 2018 · 0 comments
Labels
enhancement

Comments

@elifoster
Copy link
Contributor

Pressing the key while hovering over an item in the JEI menu doesn't do anything.
elifoster added a commit to elifoster/HuesoDeWiki that referenced this issue Mar 1, 2018
@elifoster
Eliminate complicated redundancy in renderTickEvent
c5bbc39 
Move the Gui checking to its own method, as it is used twice. This will make it easier to support additional Gui types (thinking about xbony2#38), and if necessary fix issues in the future with it because it will require one change rather than two identical changes.
Move the copying code to its own method, because it is a very long string of method calls. copyString is a much more readable way of thinking about it if you do not care about *how* the string is copied.
Switch the isCtrlKeyDown check to be non-inversed, since it is easier to think about that else clause that way.
This was referenced Mar 1, 2018
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@elifoster @xbony2