Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[weather.ha] 0.0.5b #2614

Merged
merged 3 commits into from
Apr 27, 2024
Merged

[weather.ha] 0.0.5b #2614

merged 3 commits into from
Apr 27, 2024

Conversation

Eugeniusz-Gienek
Copy link

Description

The plugin which is aimed to get the weather from the user's Home Assistant server.

Checklist:

  • My code follows the add-on rules and piracy stance of this project.
  • I have read the CONTRIBUTING document
  • Each add-on submission should be a single commit with using the following style: [script.foo.bar] 1.0.0

Additional information :

  • Submitting your add-on to this specific branch makes it available to any Kodi version equal or higher than the branch name with the applicable Kodi dependencies limits.
  • add-on development wiki page.
  • Kodi pydocs provide information about the Python API
  • PEP8 codingstyle which is considered best practise but not mandatory.
  • This add-on repository has automated code guideline check which could help you improve your coding. You can find the results of these check at Codacy. You can create your own account as well to continuously monitor your python coding before submitting to repo.
  • Development questions can be asked in the add-on development section on the Kodi forum.

Copy link
Contributor

@basrieter basrieter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my comments.

weather.ha/forecasts.example.yaml Outdated Show resolved Hide resolved
weather.ha/lib/ha_weather.py Outdated Show resolved Hide resolved
weather.ha/lib/ha_weather.py Outdated Show resolved Hide resolved
weather.ha/lib/ha_weather.py Outdated Show resolved Hide resolved
Copy link
Author

@Eugeniusz-Gienek Eugeniusz-Gienek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the "sleep" issue

Copy link
Author

@Eugeniusz-Gienek Eugeniusz-Gienek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixing timing to match other weather plugins

@basrieter basrieter merged commit 43fe339 into xbmc:nexus Apr 27, 2024
1 check passed
@Eugeniusz-Gienek Eugeniusz-Gienek deleted the nexus branch April 27, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants