Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[plugin.video.rtve]v1.0.0 #4591

Merged
merged 2 commits into from
Nov 26, 2024
Merged

[plugin.video.rtve]v1.0.0 #4591

merged 2 commits into from
Nov 26, 2024

Conversation

mcr222
Copy link

@mcr222 mcr222 commented Oct 26, 2024

Description

Addon that takes the streams from Spanish public TV RTVE and lists all series and programs.

Checklist:

  • My code follows the add-on rules and piracy stance of this project.
  • I have read the CONTRIBUTING document
  • Each add-on submission should be a single commit with using the following style: [plugin.video.foo] v1.0.0

Additional information :

  • Submitting your add-on to this specific branch makes it available to any Kodi version equal or higher than the branch name with the applicable Kodi dependencies limits.
  • add-on development wiki page.
  • Kodi pydocs provide information about the Python API
  • PEP8 codingstyle which is considered best practice but not mandatory.
  • This add-on repository has automated code guideline check which could help you improve your coding. You can find the results of these check at Codacy. You can create your own account as well to continuously monitor your python coding before submitting to repo.
  • Development questions can be asked in the add-on development section on the Kodi forum.
  • If you see no activity on your PR after a week (so at least one weekend has passed) then please go to the #kodi-dev freenode IRC channel to reach out to the team

Copy link
Contributor

@basrieter basrieter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check my comments. Main issue is that you are spamming the default loglevel far too much. Please fix that.

And make the add-on checker happy.

plugin.video.rtve/resources/lib/rtve/TestHtml.py Outdated Show resolved Hide resolved
plugin.video.rtve/resources/lib/video/Video.py Outdated Show resolved Hide resolved
plugin.video.rtve/resources/lib/video/FolderVideo.py Outdated Show resolved Hide resolved
plugin.video.rtve/resources/lib/utils/Utils.py Outdated Show resolved Hide resolved
plugin.video.rtve/resources/lib/utils/Utils.py Outdated Show resolved Hide resolved
plugin.video.rtve/resources/lib/ui/UI.py Outdated Show resolved Hide resolved
plugin.video.rtve/resources/lib/rtve/rtve.py Outdated Show resolved Hide resolved
plugin.video.rtve/resources/lib/rtve/rtve.py Outdated Show resolved Hide resolved
plugin.video.rtve/resources/lib/rtve/rtve.py Outdated Show resolved Hide resolved
plugin.video.rtve/resources/lib/rtve/rtve.py Outdated Show resolved Hide resolved
@basrieter basrieter added the Don't merge PR that should not be merged (yet) label Nov 10, 2024
@mcr222
Copy link
Author

mcr222 commented Nov 18, 2024

I think i found all logs and made them debug/error. Thanks for the feedback. Also fixed the add-on checker issues.

@basrieter
Copy link
Contributor

Thanks for you updates!

@basrieter basrieter merged commit 683a3f0 into xbmc:omega Nov 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Don't merge PR that should not be merged (yet)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants