[plugin.video.themoviedb.helper] 5.2.25

[jurialmunkey]

Description

Add and update TMDbHelper for Nexus and higher.

NOTE
Requires script.module.jurialmunkey to be updated in this PR first to meet dep requirements: xbmc/repo-scripts#2624

Acts as a helper plugin to generate widgets and retrieve details from online APIs for skinners. See wiki for full feature list
https://github.com/jurialmunkey/plugin.video.themoviedb.helper/wiki

Note an older version exists on Matrix repo. However, I'm submitting new for Nexus as the current version now uses the new infotag setters and so now only works on Nexus or higher.

Checklist:

• My code follows the add-on rules and piracy stance of this project.
• I have read the CONTRIBUTING document
• Each add-on submission should be a single commit with using the following style: [plugin.video.foo] v1.0.0

Additional information :

• Submitting your add-on to this specific branch makes it available to any Kodi version equal or higher than the branch name with the applicable Kodi dependencies limits.
• add-on development wiki page.
• Kodi pydocs provide information about the Python API
• PEP8 codingstyle which is considered best practice but not mandatory.
• This add-on repository has automated code guideline check which could help you improve your coding. You can find the results of these check at Codacy. You can create your own account as well to continuously monitor your python coding before submitting to repo.
• Development questions can be asked in the add-on development section on the Kodi forum.
• If you see no activity on your PR after a week (so at least one weekend has passed) then please go to the #kodi-dev freenode IRC channel to reach out to the team

[jurialmunkey]

packaging.version.InvalidVersion: Invalid version: '5.2.25~nexus'

I don't understand this error? This is a valid version afaik.
Is the tilde ~ not allowed in the repo?

EDIT: I've removed the ~nexus suffix so the checker doesn't complain.

[jurialmunkey]

I've fixed all the errors. Checker is still complaining because of the dependency module that needs to go in first but otherwise should be clean now.

[Hitcher]

Does the addon checker need running again for this (and script.skinvariables) now that script.module.jurialmunkey v0.1.18 has been committed?

[jurialmunkey]

Does the addon checker need running again for this (and script.skinvariables) now that script.module.jurialmunkey v0.1.18 has been committed?

Yeah, it looks like Bas tried yesterday but it hadn't quite hit the repo yet so still failed. I just retriggered now by force pushing a blank commit amend and looks like green light now.

[kris06]

major problem on search, 'the accents are not supported' on Fuse

Example
(en francais) présumé innocent is invalid
presumed innocent is valid research

[Hitcher]

@kris06 this isn't the correct place for issues. Please go here instead: https://github.com/jurialmunkey/plugin.video.themoviedb.helper/issues

[Hitcher]

Is there any particular reason this is being overlooked?
Anything we can do to help get it merged?

[basrieter]

Is there any particular reason this is being overlooked? Anything we can do to help get it merged?

It's not being overlooked, but the PR is huge, so it takes up a lot of time to review. And thus is not a PR that we can quickly check and merge when we have some minutes lefts.

I will start a review today and see if I can fine a larger slot of time. But for the future: if you keep the PR's a bit smaller, things do go faster: 2 smaller PR's (after one another) will go faster than one huge one.

[basrieter]

Did a first check of non-Python stuff.

[basrieter]

Any reason why reuselanguageinvoker is disabled? This will require a new Python invoker with each run, instead of re-using the existing one with subsequent plugin requests. Re-using saves a lot of CPU and is faster.

[jurialmunkey]

Because of this long standing bug which causes Kodi to hang and/or crash when reuselanguageinvoker plugins are used as widgets: xbmc/xbmc#21653

[Hitcher]

It's not being overlooked, but the PR is huge, so it takes up a lot of time to review. And thus is not a PR that we can quickly check and merge when we have some minutes lefts.

Thanks for the update.

I will start a review today and see if I can fine a larger slot of time.

Thanks, I really appreciate it as this is the last dependency needed before I can submit my skin to the Omega repo.

[jurialmunkey]

I will start a review today and see if I can fine a larger slot of time. But for the future: if you keep the PR's a bit smaller, things do go faster: 2 smaller PR's (after one another) will go faster than one huge one.

Yeah this is my fault. I'm really sorry about getting so tardy on submitting updates as I know this is a massive pita to review.

BTW - the plugin is on the Matrix repo but I needed to make a new submission against Nexus as the info tag changes means it no longer works on Matrix -- it's still huge but if you compare against that version might give some indication of where there are trivial vs. significant changes. A lot is refactoring pushing things around as I try to unpick some of my poorer choices from when I was beginning to learn python (my eventual goal was to modularise things to make it all a bit more manageable but release cycle beat time/motivation available - so unfortunately it's still a mammoth).

If it helps at all here's the compare from my repo for the tag of the version in Matrix repo (v4.10.14) and this PR:
https://github.com/jurialmunkey/plugin.video.themoviedb.helper/compare/v4.10.14..v5.2.25

[basrieter]

So it took me quite some time but I got through it. Hopefully the future PR's are smaller :)

[Hitcher]

That's awesome news. Many thanks basieter, it's really appreciated.

[jurialmunkey]

So it took me quite some time but I got through it. Hopefully the future PR's are smaller :)

Yes definitely will be I promise! Really appreciate you taking the time to review.