[plugin.audio.tripler] 3.0.0

[molzy]

Description

A Kodi plugin for Triple R: an independent community radio station in Melbourne, Australia.

Version 3.0.0 is a complete revamp of this plugin.

• Rewritten with more flexible parser
• More content added from website
• Improved user interface and menus
• Browsing programs by name and date now possible
• Broadcast track playlists are available
• Support for playing music through Bandcamp, YouTube and indigiTUBE
• Support for searching for music content by title and artist
• Subscriber-only giveaways can now be entered by signing in

Code location: https://github.com/molzy/plugin.audio.tripler/

Checklist:

• My code follows the add-on rules and piracy stance of this project.
• I have read the CONTRIBUTING document
• Each add-on submission should be a single commit with using the following style: [plugin.video.foo] v1.0.0

Additional information :

• Submitting your add-on to this specific branch makes it available to any Kodi version equal or higher than the branch name with the applicable Kodi dependencies limits.
• add-on development wiki page.
• Kodi pydocs provide information about the Python API
• PEP8 codingstyle which is considered best practice but not mandatory.
• This add-on repository has automated code guideline check which could help you improve your coding. You can find the results of these check at Codacy. You can create your own account as well to continuously monitor your python coding before submitting to repo.
• Development questions can be asked in the add-on development section on the Kodi forum.
• If you see no activity on your PR after a week (so at least one weekend has passed) then please go to the #kodi-dev freenode IRC channel to reach out to the team

[romanvm]

@basrieter is this addon OK?

[basrieter]

@basrieter is this addon OK?

Let me check in about 30 mins

[basrieter]

I have some comments that I would like to see addressed. Nothing big.

I do have to day that a bit more code commenting (especially some classes/methods) would have made it a lot easier to understand what you are doing.

[basrieter]

Please have a look at my (minor) comments.

[basrieter]

Any update @molzy ?

[molzy]

Hey @basrieter , have been away for a while but just made the minor changes, thanks for taking a look.

Sorry about the lack of clarity in the code, it's a little bit abstracted. The intent of the scraper.py file is to contain the website scraping logic for the Kodi addon, while being usable outside of the Kodi addon as a standalone Python program to produce json output. Left over from implementing this functionality was the weak attempt at Py2 compat and the small usage of stderr.

I've removed both of these as per your comments since they aren't necessary for the standalone functionality. Thanks for the nudge to clean up! Let me know if there's anything else you would like me to clarify or change.

[romanvm]

@basrieter Is it ok now?