[plugin.video.invidious] 0.2.2+nexus.0

[petterreinholdtsen]

A privacy-friendly way of watching YouTube content. Uses the great Invidious web service's API to do the heavy lifting.

Third nexus repository release from new repository.

Checklist:

• My code follows the add-on rules and piracy stance of this project.
• I have read the CONTRIBUTING document
• Each add-on submission should be a single commit with using the following style: [plugin.video.foo] v1.0.0

[ramiro]

@petterreinholdtsen there is a typo in the PR title invidoius -> invidious

[petterreinholdtsen]

[Ramiro Morales]

@petterreinholdtsen there is a typo in the PR title `invidoius` -> `invidious`

Thanks. Fixed there and in the commit.

…

-- Happy hacking Petter Reinholdtsen

[Lunatixz]

Thank you for your submission, please address the issues and we can proceed.

[Lunatixz]

Please remove this file from the PR request.

[petterreinholdtsen]

No problem. Why do you want to hide the recipe on how to update the translations, build a distribution zip and make releases?

[solbu]

Why do you want to hide the recipe on how to update the translations, build a distribution zip and make releases?

I guess they have their own way to do releases.
I always branch out and create PRs from the branch, and keep my own potential none desired custom scripts to my own master branch.

(Btw, I was the origin for the Makefile. I use it for maintaning addon releases in my own kodi repo.)

[petterreinholdtsen]

Thank you for trying to help me here. :) [Lunatixz]

Google is your friend :) Please resize to 1080p. https://i0.wp.com/datahorde.org/wp-content/uploads/2020/09/Invidious-Logo.png

What do you mean? It is already 1080 pixels wide: % file resources/fanart.png resources/fanart.png: PNG image data, 1080 x 540, 8-bit/color RGB, non-interlaced %

If you don't understand the new API there are topics on the Kodi forums to help; ie. your lack of understanding != broken API.

Good. Is how to use the new API documented outside comments and fragments in the forum, ie some consistent instructions by someone who know the new API? I have trawled the forum trying to figure out how to use it without any luck so far. I only find code fragments that do not work when I test it, and have no idea if it is because something changed within Kodi or the forum posts are just wrong.

The wrapper is there to offer backward/forward compatibility... in your case since you are only familiar with setinfo, its a bridge to the new API. If you don't understand the new API there are topics on the Kodi forums to help; ie. your lack of understanding != broken API. The wrapper is there to offer backward/forward compatibility... in your case since you are only familiar with setinfo, its a bridge to the new API.

I am not really familiar with any of them, so it is no loss for me to switch to a newer API, if I can find a howto or explanation on how to use it.

The readme attached to the infotagger project has excellent examples.

As you can see from my comment earlier, the excellent infotagger examples did not work for me, and I fail to understand why. The addon.xml dependency statement to depend on infotagger just made my addon uninstallable. I expected a repository including infotagger to be available in the default kodi setup for kodi 20. Is this wrong?

…

-- Happy hacking, Petter Reinholdtsen

[Lunatixz]

@petterreinholdtsen Lets start with your addon.xml... below is how it should appear on your end.... Make sure you have the dependency installed to Kodi (its available in the official repository).

    <requires>
        <import addon="xbmc.python" version="3.0.0"/>
        <import addon="script.module.requests" version="2.22.0"/>
        <import addon="script.module.inputstreamhelper" version="0.5.2"/>
        <import addon="script.module.infotagger" version="0.0.5" />
    </requires>

add below to invidious_plugin.py
from infotagger.listitem import ListItemInfoTag

at lines below change list_item.setInfo("video", {'title':'kilroy'}) to

info_tag = ListItemInfoTag(list_item, 'video')
info_tag.set_info({'title':'kilroy'})

https://github.com/xbmc/repo-plugins/pull/4363/files#diff-70e6e459897139bee66316b0f474d4e178c727fa69d348201e6d843f646bffffR135

https://github.com/xbmc/repo-plugins/pull/4363/files#diff-70e6e459897139bee66316b0f474d4e178c727fa69d348201e6d843f646bffffR225

[petterreinholdtsen]

[Lunatixz]

@petterreinholdtsen Lets start with your addon.xml... below is how it should appear on your end.... Make sure you have the dependency installed to Kodi (its available in the official repository).

Thank you. I gave this a go using version 0.0.5, but the dependency was not installed by Kodi when I tried to install the addon zip file using the 'Instal from zip file' menu option in the add-on browser menu. Kodi refused to install my new addon version because its dependency are missing. What do you mean by 'make sure you have the dependency installed'? For other addons the required dependency have been installed automatically by Kodi, as far as I remember. Is this not the case for infotagger? Am I missing some official repository in my LibreELEC installation?

add below to invidious_plugin.py

Seem to be correct to me. My edition is still available from <URL: https://github.com/petterreinholdtsen/kodi-invidious-plugin/tree/obsolete-setInfo >

…

-- Happy hacking Petter Reinholdtsen

[Lunatixz]

I'm not sure why the dependency isn't installing... its live in the repo: http://mirrors.kodi.tv/stats?downloadstats&filter=script.module.infotagger

I would manually download infotaggers zip and install it...

[petterreinholdtsen]

[Lunatixz]

I would manually download infotaggers zip and install it...

Thank you for your patience. This brought me along a path where I finally got it working. In the end it was an embarrasing misconfiguration on my part. Do not ask. :) A new release without the obsolete setInfo() calls are now available for your review. :)

…

-- Happy hacking Petter Reinholdtsen

[Lunatixz]

@petterreinholdtsen Great, glad you worked it out... only one issue remaining. The fanart is not 1920x1080,
ERROR: fanart should have either 1280x720 or 1920x1080 or 3840x2160 but it has 1080x540

[petterreinholdtsen]

[Lunatixz]

@petterreinholdtsen Great, glad you worked it out... only one issue remaining. The fanart is not 1080x1920,

I am on it. I assume 1080x1920 is a typo, and you ment 1920x1080.

`ERROR: fanart should have either 1280x720 or 1920x1080 or 3840x2160 but it has 1080x540`

Can the fanart be SVG, or must it be a PNG bitmap?

…

-- Happy hacking Petter Reinholdtsen

[Lunatixz]

png or jpg.

[petterreinholdtsen]

I mocked up a fanart.png in inkscape. Hope it is acceptable. I did not include the original .svg, assuming it is as unwelcome as the makefiles and will only keep it in the upstream git repo for how.

…

-- Happy hacking Petter Reinholdtsen

[petterreinholdtsen]

Is there anything more for me to do to get this into wider distribution?

[romanvm]

LGTM