hdev-703-xav-airdrop #3
Conversation
tracyarciaga
requested review from
0xAplki,
chris247474,
mystbrent and
schystz
| const addresses: string[] = [] | ||
| const snapshotBlockNumber = 15281097 | ||
|
|
||
| // 1 - get rnbwContract contract instance |
There was a problem hiding this comment.
question - is this code forked?
If not, I guess we need to probably create a unit test here?
There was a problem hiding this comment.
I'm having issues in using the command yarn hardhat xav-airdrop --network mainnet :(
There was a problem hiding this comment.
@tracyarciaga i'll leave it to others to do a deeper review, but i did some quick manual searches of xRNBW holders i know (some of our seed investors) and this address for example 0xC8E9bd09A38d27331DC5bDC2a7d4EB254F2aA61C isn’t in the xRNBW airdrop list (the one you sent me https://docs.google.com/spreadsheets/d/11G_UJ2_Wjf8BB0uY5wRFPKWHyFjUFzdiG_X9v9WbIlw/edit#gid=424991193) even if it was transferred xRNBW before Aug 5 8am UTC
scripts/constants/abi/rnbw.ts
Outdated
| @@ -0,0 +1,10 @@ | |||
| export const internalRnbwHolders = [ | |||
There was a problem hiding this comment.
@tracyarciaga the comments say xRNBW but the filenames and variables say rnbw. which one are we getting?
There was a problem hiding this comment.
@ctverceles I fixed the naming conventions
For the sheet it should be this one -> https://docs.google.com/spreadsheets/d/11G_UJ2_Wjf8BB0uY5wRFPKWHyFjUFzdiG_X9v9WbIlw/edit#gid=1457496626
| const csvExporter = new ExportToCsv(options) | ||
| const airdropList: AirdropList[] = [] | ||
| const addresses: string[] = [] | ||
| const snapshotBlockNumber = 15281097 |
There was a problem hiding this comment.
@tracyarciaga how did we get this btw? is this aug 5 8am UTC?
There was a problem hiding this comment.
@ctverceles Yes it's Aug-05-2022 08:00:12 AM +UTC here
https://etherscan.io/block/15281097
The block before that is Aug-05-2022 07:59:59 AM +UTC
Description of Changes
Added script to generate addresses eligible for XAV airdrop
Link to Jira Ticket
How To Test
Run the script
yarn hardhat xav-airdrop --network mainnet
Can use etherscan's token check tool to verify address balance at block height.
https://etherscan.io/tokencheck-tool
Developer Checklist:
feature/HDF-XXX-descriptionReviewers Checklist: