🌭 fail only when getSGDRate is called but CMC_API_KEY is not set

xave-finance · Aug 8, 2024 · a73549c · a73549c
1 parent c8afc2f
commit a73549c
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/scripts/util/cmc.ts b/scripts/util/cmc.ts
@@ -1,11 +1,6 @@
 import axios from 'axios'
 const CMC_API_KEY = process.env.CMC_API_KEY || ''
 
-if (!CMC_API_KEY) {
-  // fail early
-  throw new Error('CMC_API_KEY is not set')
-}
-
 interface QuoteData {
   data: {
     [key: string]: {
@@ -19,6 +14,11 @@ interface QuoteData {
 }
 
 export const getSGDRate = async (): Promise<number> => {
+  if (!CMC_API_KEY) {
+    // fail early
+    throw new Error('CMC_API_KEY is not set')
+  }
+
   try {
     const response = await axios.get<QuoteData>(
       'https://pro-api.coinmarketcap.com/v2/cryptocurrency/quotes/latest?id=2808',

diff --git a/scripts/xsgd-rewards-v2.ts b/scripts/xsgd-rewards-v2.ts
@@ -31,6 +31,8 @@ export const snapshotXSGDRewards = async (
   hre: HardhatRuntimeEnvironment,
   epochDate: string // YYYY-MM format, e.g. 2023-03 for March 2023
 ) => {
+  // Get the current XSGD rate
+  const rate = await getSGDRate()
   const [deployer] = await hre.ethers.getSigners()
   const FXPoolContract = new hre.ethers.Contract(
     POOL_ADDRESS,
@@ -119,7 +121,6 @@ export const snapshotXSGDRewards = async (
     reward: string
   }[] = []
 
-  const rate = await getSGDRate()
   const xsgdRate = parseEther(`${rate}`)
   console.log(`RATE: 1 XSGD = ${formatEther(xsgdRate)} USD`)