Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump GitHub Actions #260

Merged
merged 9 commits into from
Jun 24, 2024
Merged

Bump GitHub Actions #260

merged 9 commits into from
Jun 24, 2024

Conversation

scottyhq
Copy link
Contributor

Address #259

@scottyhq scottyhq marked this pull request as draft May 20, 2024 15:48
@lsetiawan lsetiawan closed this May 20, 2024
@lsetiawan lsetiawan reopened this May 20, 2024
@scottyhq scottyhq marked this pull request as ready for review June 21, 2024 18:25
@scottyhq scottyhq requested review from lsetiawan and andersy005 June 21, 2024 18:26
@scottyhq
Copy link
Contributor Author

I think I've finally cracked the previews by separating "build" and "deploy" into separate workflows. Deploy uses workflow_run: , which is similar to pull_request_target in that it runs on the main branch such that forks can't modify it.

Made a small pull request to the surge-preview action to make this work afc163/surge-preview#297 (comment)

Tested here relativeorbit/sarbook#7

name: Pull Request Preview

on:
workflow_run:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This only runs on the main branch, so need to merge to actually see it in action

@scottyhq scottyhq requested a review from JessicaS11 June 21, 2024 21:25
@scottyhq
Copy link
Contributor Author

Going to go ahead and merge, can always revert or disable the preview workflow in the future

@scottyhq scottyhq merged commit 2185bf4 into xarray-contrib:main Jun 24, 2024
3 checks passed
Copy link

😭 Deploy PR Preview cf65eab failed. Build logs

🤖 By surge-preview

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants