-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update indexing material #192
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Very nice! I just took a quick look, will do a more thorough review tomorrow.
Perhaps we can copy the exercises over? That notebook also has some date time indexing material that could be copied? Can you add entries in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove the logo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you'll need one or two more lines to explain "orthogonal" indexing.
We should also link to the xarray docs appropriately.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add a new subsection for "pointwise indexing"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For masking, another motivation is selecting regions that are not regular: like lat and lon ranges on a curvilinear grid. A figure might be useful to illustrate the difference. "rasm"
is a useful dataset for this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's use the myst syntax where we can instead of alerts and bold font
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Masking and isin
can be grouped under "Boolean indexing". They could be moved to its own notebook.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can skip "align and reindex". Reindexing can be its own section left for some future work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your comments.
I significantly updated this notebook based on your comments:
I added a section called orthogonal indexing. I tried to add the pointwise terminology as you recommended.
For the boolean masking :
I created a separate notebook for Boolean masking/indexing (as you recommended).
I updated the notebook to use rasm
dataset and created a specific section/exercise telling them why they cannot use sel
for such datasets for selecting regions.
Here's a proposal for organizing:
What do you think? We've been evolving towards breaking up the material in to small pieces so it's easy to choose subsets for a syllabus. We'll need to add the parts you want to cover to the |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
@dcherian I am not sure why the JupyterBuild of this notebook fails. It complains about the redirect and a page already existing:
Should I manually deleted the cached htmls ? |
You can change the key to force a new cache: xarray-tutorial/.github/workflows/main.yaml Lines 32 to 33 in 2ca47a9
|
i usually delete stale cache via the actions UI, and this seems to invalidate it and force a new cache (under the same key though) |
thank you for putting this together, @negin513! i intend to push changes to this PR tomorrow and sunday |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Thanks all. This is looking great. I pushed some minor edits. Some major comments:
|
We only have 30 minutes for the indexing topic, so perhaps just do only the Advanced and Vectorized Indexing notebook? Given that I'm just going to merge here. Thanks @negin513 and @andersy005 ! |
Sounds great. Thanks @dcherian. Do we have a schedule now and how long each topic is going to take? |
* upstream/main: Update indexing material (xarray-contrib#192) Migrate to exercise syntax (xarray-contrib#196) Bump pangeo/base-image from 2023.06.20 to 2023.07.05 in /.devcontainer (xarray-contrib#193) Add Nebari-specific instructions for SciPy 2023 (xarray-contrib#195) Add contributors image (xarray-contrib#194) Computational pattern tutorial edits (xarray-contrib#186) Housekeeping + clean up sidebar (xarray-contrib#190)
Adding two new notebooks in support of SciPy 2023:
The first notebook includes comprehensive coverage of all basic indexing and can basically replace the 02.1_working_with_labeled_data.ipynb. But I wanted to first ask for feedback before removing the other notebook.
The second notebook includes :
isin
, and masking usingwhere
Relevant Issue: #170
We can add materials for Fancy Datetime Indexing here @andersy005 .