Added pagination helper #1741
Closed
Added pagination helper #1741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've implemented something similar in #1498 🤔 |
|
I guess iterators would also be nice for this once they land 🤔 |
|
Any feedback here? I still think this would be a good addition. |
|
There's not a lot of Gitlab specific things in there. It increases the API for something that could live outside of this package. For some reason I prefer the aesthetics of #1498 Also maybe we should wait for "official" support of Iterator in Go ? |
|
I think I'm going for PR #1875 for adding a form of pagination support. If you think that solution can or should be changed/updated (including naming or ergonomics) than please comment on that PR so we can get to some kind of consensus before merging that one 😏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a pretty flexible pagination helper.
It allows to abort on certain criterias and also to process the items after each page if wanted.
Open for discussion!