Optimize load_verify_locations to Improve Import Performance #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dosine-staging[bot]](https://avatars.githubusercontent.com/in/697727?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses the performance regression introduced between versions 2.31.0 and 2.32.3, where import time increased by approximately 25%. The root cause was identified as the
load_verify_locations()function being executed at import time due to changes in psf#6667.To resolve this, the
load_verify_locationsfunction call has been deferred to runtime, ensuring it does not impact the import performance. The changes are confined tosrc/requests/adapters.pyand include adjustments to the import statements and theproxy_manager_formethod to conditionally importSOCKSProxyManageronly when necessary.This optimization should restore the import performance to its previous state without affecting the functionality.