Add first controller from ILightThat #4465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derwin12
reviewed
Apr 14, 2024
derwin12
approved these changes
Apr 14, 2024
derwin12
pushed a commit
to derwin12/xLights
that referenced
this pull request
Nov 18, 2024
* Add first controller from ILightThat * Fix build issue on Linux * Add colour order support to ILightThat Controllers * Correct code review comments * Further code review fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New controller venture in the UK.
Getting scaffolding in for new controller, running a custom ESP32 firmware. Will most likely need revisiting as we expand and add features, but there's enough here to be useful.
Very open to comments/suggestions/rework as required. Keen to make this as easy as possible for code maintenance, etc, so please do let me know if you'd prefer anything revised.
Thanks,
Pete