feat: signer interactivity #617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xJonathanLEI
force-pushed
the
dev/signer_interactivity
branch
2 times, most recently
from
ce1d856 to
919f89c
Compare
Makes signer implementations specify whether a signing operation is "interactive" (or just expensive). Utilizing this new information, `Account` and `AccountFactory` now make more informed decisions on whether to request real signatures for different types of operations. The most significant benefit of this change is allowing using hardware wallet without excessive unnecessary signing requests.
xJonathanLEI
force-pushed
the
dev/signer_interactivity
branch
from
919f89c to
7ef12c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes signer implementations specify whether a signing operation is "interactive" (or just expensive). Utilizing this new information,
AccountandAccountFactorynow make more informed decisions on whether to request real signatures for different types of operations.The most significant benefit of this change is allowing using hardware wallet without excessive unnecessary signing requests.
This PR is made a breaking change, despite the possibility of maintaining backward compatibility by providing default implementations of the new trait methods. This is because #611 has already introduced a breaking change on
starknet-signersanyway.Breaking changes include:
get_invoke_requestandget_declare_requestmethods are no longerpub; it was a mistake making them public in the first place;Signer,Account, andAccountFactorywithout default impls.