feat: replace Pedersen implementation with type-rs #614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@xJonathanLEI I see these kind of errors in the CI in different prs, is it normal? I think we have something strange here, not linked to the pr, wdyt? |
xJonathanLEI
force-pushed
the
feat/replace-pedersen-impl-with-typers
branch
from
fa8b556 to
fbd54fd
Compare
|
Hi @tcoratger there was a node failure of the Sepolia node I hosted for running the tests. It should be all good now. |
xJonathanLEI
force-pushed
the
feat/replace-pedersen-impl-with-typers
branch
from
fbd54fd to
696728b
Compare
tcoratger
approved these changes
Jul 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #609
Removes current Pedersen implementation & replaces with the one implemented in
type-rscc @tcoratger @xJonathanLEI please review and check if this is what the #609 meant (that's our understanding).