Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: serialization ReceiptBlock #604

Merged
merged 1 commit into from
Jun 18, 2024
Merged

fix: serialization ReceiptBlock #604

merged 1 commit into from
Jun 18, 2024

Conversation

jbcaron
Copy link
Contributor

@jbcaron jbcaron commented Jun 17, 2024

  • the macro #[serde_as] must be declared before #[derive(...)]
  • the serialization of the block_hash as a FieldElement was done in base 10 but this is correct with Felt

@tcoratger tcoratger merged commit 36ec1d6 into xJonathanLEI:master Jun 18, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tcoratger tcoratger tcoratger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jbcaron @tcoratger