Improve poseidon hash perf by using assign operators #569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Rebasing onto |
xJonathanLEI
force-pushed
the
poseidon-hash
branch
from
8bb1b0f to
77ebdf6
Compare
|
Running the benchmark on my machine the perf changes from this seems to be within noise threshold. I'm not sure about this. Need to test a bit more I guess. |
|
@tcoratger This PR seems no longer relevant as the new |
|
Also it will be superseded by anything that comes out of #608 anyways. Closing now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request aims to enhance the performance of the poseidon hash by utilizing assignment multiplication (
mul_assign) and addition (add_assign) operators whenever possible. By doing so, unnecessary copies are avoided, resulting in improved overall performance.