Replace ELEMENT_UPPER_BOUND by FieldElement::MAX in ecdsa
#566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closed, didn't read well the diff between |
|
Yep yep. IIRC this was done specifically to align with the official impl from the StarkWare C++ lib back in the day. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
In the
FieldElementmodule, we've already defined aMaxfield to indicate the maximum value a field element can take before the modulus is reached, specifically equal to 2^251 + 17 * 2^192. Consequently, there's no need to redefine this value in the crypto ecdsa file. By leveraging the existing definition fromFieldElement, we can ensure consistency and avoid redundancy in our codebase.