feat(sequencer): deprecated endpoint error code #510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see you're adding 2 things:
1 has been implemented by #513 (in a more idiomatic way too). I will now rebase this PR to only include 2. Thanks for the fix. |
xJonathanLEI
force-pushed
the
fixed_jsonrpc_error_handle
branch
from
67b8285 to
667839f
Compare
xJonathanLEI
changed the title
|
In fact, the best way to deal with the deprecated endpoints would be to simply remove them for good, but let's leave that for another day. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #509
@xJonathanLEI