fix pedersen

xJonathanLEI · Apr 25, 2024 · 9603f14 · 9603f14
1 parent 8d83f08
commit 9603f14
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 9 deletions.
diff --git a/starknet-core/src/types/contract/legacy.rs b/starknet-core/src/types/contract/legacy.rs
@@ -280,17 +280,19 @@ struct AttributeForHintedHash;
 impl From<LegacyEntrypointOffset> for u64 {
     fn from(value: LegacyEntrypointOffset) -> Self {
         match value {
-            LegacyEntrypointOffset::U64AsHex(inner) => inner,
-            LegacyEntrypointOffset::U64AsInt(inner) => inner,
+            LegacyEntrypointOffset::U64AsHex(inner) | LegacyEntrypointOffset::U64AsInt(inner) => {
+                inner
+            }
         }
     }
 }
 
 impl From<LegacyEntrypointOffset> for Felt {
     fn from(value: LegacyEntrypointOffset) -> Self {
         match value {
-            LegacyEntrypointOffset::U64AsHex(inner) => inner.into(),
-            LegacyEntrypointOffset::U64AsInt(inner) => inner.into(),
+            LegacyEntrypointOffset::U64AsHex(inner) | LegacyEntrypointOffset::U64AsInt(inner) => {
+                inner.into()
+            }
         }
     }
 }

diff --git a/starknet-crypto/src/pedersen_hash.rs b/starknet-crypto/src/pedersen_hash.rs
@@ -4,18 +4,15 @@ use starknet_types_core::felt::Felt;
 
 use crate::pedersen_points::*;
 
-// const SHIFT_POINT: Result<ProjectivePoint, CurveError> =
-//     ProjectivePoint::from_affine(curve_params::SHIFT_POINT.x(), curve_params::SHIFT_POINT.y());
-
 /// Computes the Starkware version of the Pedersen hash of x and y. All inputs are little-endian.
 ///
 /// ### Arguments
 ///
 /// * `x`: The x coordinate
 /// * `y`: The y coordinate
 pub fn pedersen_hash(x: &Felt, y: &Felt) -> Felt {
-    let x = x.to_bits_be();
-    let y = y.to_bits_be();
+    let x = x.to_bits_le();
+    let y = y.to_bits_le();
 
     // Preprocessed material is lookup-tables for each chunk of bits
     let table_size = (1 << CURVE_CONSTS_BITS) - 1;