updated cargo clippy fix for starknet-core, starknet-contract and sta…

…rknet-accounts

Cargo.toml

@@ -54,7 +54,6 @@ no_unknown_fields = [
 
 [workspace.lints]
 rust.missing_debug_implementations = "warn"
-rust.unreachable_pub = "warn"
 rust.unused_must_use = "deny"
 rust.rust_2018_idioms = { level = "deny", priority = -1 }
 rustdoc.all = "warn"

starknet-accounts/tests/single_owner_account.rs

@@ -31,6 +31,7 @@ fn create_sequencer_client() -> SequencerGatewayProvider {
 }
 
 fn create_jsonrpc_client() -> JsonRpcClient<HttpTransport> {
+    #[allow(clippy::or_fun_call)]
     let rpc_url = std::env::var("STARKNET_RPC")
         .unwrap_or("https://juno.rpc.sepolia.starknet.rs/rpc/v0_7".into());
     JsonRpcClient::new(HttpTransport::new(url::Url::parse(&rpc_url).unwrap()))

starknet-contract/Cargo.toml

@@ -27,3 +27,6 @@ rand = { version = "0.8.5", features=["std_rng"] }
 starknet-signers = { version = "0.9.0", path = "../starknet-signers" }
 tokio = { version = "1.27.0", features = ["full"] }
 url = "2.3.1"
+
+[lints]
+workspace = true

starknet-core/Cargo.toml

@@ -49,3 +49,6 @@ harness = false
 [[bench]]
 name = "sierra_class_hash"
 harness = false
+
+[lints]
+workspace = true

starknet-core/src/chain_id.rs

@@ -46,7 +46,6 @@ mod test {
             ("SN_GOERLI2", TESTNET2),
             ("SN_SEPOLIA", SEPOLIA),
         ]
-        .into_iter()
         {
             assert_eq!(cairo_short_string_to_felt(text).unwrap(), felt);
         }

starknet-core/src/crypto.rs

@@ -49,7 +49,7 @@ pub use errors::{EcdsaSignError, EcdsaVerifyError};
 pub fn compute_hash_on_elements(data: &[Felt]) -> Felt {
     let mut current_hash = Felt::ZERO;
 
-    for item in data.iter() {
+    for item in data {
         current_hash = pedersen_hash(&current_hash, item);
     }
 

starknet-core/src/serde/byte_array.rs

@@ -24,7 +24,7 @@ pub mod base64 {
     impl<'de> Visitor<'de> for Base64Visitor {
         type Value = Vec<u8>;
 
-        fn expecting(&self, formatter: &mut Formatter) -> alloc::fmt::Result {
+        fn expecting(&self, formatter: &mut Formatter<'_>) -> alloc::fmt::Result {
             write!(formatter, "string")
         }
 

starknet-core/src/serde/num_hex.rs

@@ -22,7 +22,7 @@ pub mod u64 {
     impl<'de> Visitor<'de> for NumHexVisitor {
         type Value = u64;
 
-        fn expecting(&self, formatter: &mut Formatter) -> alloc::fmt::Result {
+        fn expecting(&self, formatter: &mut Formatter<'_>) -> alloc::fmt::Result {
             write!(formatter, "string")
         }
 

starknet-core/src/serde/unsigned_field_element.rs

@@ -8,10 +8,13 @@ use serde_with::{DeserializeAs, SerializeAs};
 
 use starknet_types_core::felt::Felt;
 
+#[derive(Debug)]
 pub struct UfeHex;
 
+#[derive(Debug)]
 pub struct UfeHexOption;
 
+#[derive(Debug)]
 pub struct UfePendingBlockHash;
 
 struct UfeHexVisitor;
@@ -39,7 +42,7 @@ impl<'de> DeserializeAs<'de, Felt> for UfeHex {
 impl<'de> Visitor<'de> for UfeHexVisitor {
     type Value = Felt;
 
-    fn expecting(&self, formatter: &mut Formatter) -> alloc::fmt::Result {
+    fn expecting(&self, formatter: &mut Formatter<'_>) -> alloc::fmt::Result {
         write!(formatter, "string")
     }
 
@@ -75,7 +78,7 @@ impl<'de> DeserializeAs<'de, Option<Felt>> for UfeHexOption {
 impl<'de> Visitor<'de> for UfeHexOptionVisitor {
     type Value = Option<Felt>;
 
-    fn expecting(&self, formatter: &mut Formatter) -> alloc::fmt::Result {
+    fn expecting(&self, formatter: &mut Formatter<'_>) -> alloc::fmt::Result {
         write!(formatter, "string")
     }
 
@@ -118,7 +121,7 @@ impl<'de> DeserializeAs<'de, Option<Felt>> for UfePendingBlockHash {
 impl<'de> Visitor<'de> for UfePendingBlockHashVisitor {
     type Value = Option<Felt>;
 
-    fn expecting(&self, formatter: &mut Formatter) -> alloc::fmt::Result {
+    fn expecting(&self, formatter: &mut Formatter<'_>) -> alloc::fmt::Result {
         write!(formatter, "string")
     }