ci: allow some nightly lints

xJonathanLEI · Apr 29, 2024 · 5528f94 · 5528f94
1 parent f33d352
commit 5528f94
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 5 deletions.
diff --git a/.github/workflows/lint.yaml b/.github/workflows/lint.yaml
@@ -78,11 +78,19 @@ jobs:
           components: "clippy"
           override: true
 
+      - name: "Set allowed lints"
+        run: |
+          if [ "${{ matrix.toolchain }}" == "nightly" ] then
+            echo "ALLOWED=-A non_local_definitions" >> $GITHUB_ENV
+          else
+            echo "ALLOWED=" >> $GITHUB_ENV
+          fi
+
       - name: "Run Clippy (default)"
         run: |
-          cargo clippy --all --all-targets -- -D warnings
+          cargo clippy --all --all-targets -- -D warnings $ALLOWED
 
       - name: "Run Clippy (no_std)"
         run: |
-          cargo clippy --package starknet-crypto --no-default-features -- -D warnings
-          cargo clippy --package starknet-crypto --no-default-features --features alloc -- -D warnings
+          cargo clippy --package starknet-crypto --no-default-features -- -D warnings $ALLOWED
+          cargo clippy --package starknet-crypto --no-default-features --features alloc -- -D warnings $ALLOWED
diff --git a/starknet-crypto/src/test_utils.rs b/starknet-crypto/src/test_utils.rs
@@ -1,5 +1,3 @@
-#![cfg(test)]
-
 use crate::FieldElement;
 
 pub fn field_element_from_be_hex(hex: &str) -> FieldElement {